Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update minifront bundled assets #5090

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Conversation

conorsch
Copy link
Contributor

@conorsch conorsch commented Feb 14, 2025

Describe your changes

Built from head on web repo 28e2ccb6a8255f793866e5f59d8d334ab32510ad. Tested locally, and I see the new version displayed in my local browser, in the footer.

Issue ticket number and link

Closes #4965.

Testing and review

If you have the patience, pull down this branch and use a local node with prax. On the frontend page, you should see:

minifront-bundle-after

Which maps to this commit: penumbra-zone/web@28e2ccb and notably includes the skip widget fix immediately preceding it, in penumbra-zone/web@03597b7

Checklist before requesting a review

  • I have added guiding text to explain how a reviewer should test these changes.

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    no changes to consensus logic, just updating the already-merged web ui changes, to keep the bundled pd version up to date.

Built from head on web repo 28e2ccb6a8255f793866e5f59d8d334ab32510ad.
Tested locally, and I see the new version displayed in my local browser,
in the footer.
@conorsch conorsch requested a review from TalDerei February 14, 2025 20:26
Copy link
Collaborator

@TalDerei TalDerei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@erwanor erwanor merged commit 109053b into main Feb 14, 2025
9 of 10 checks passed
@erwanor erwanor deleted the pd-update-minifront-2025-02 branch February 14, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants