penumbra: use [email protected]
#5006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tacks on a new integration test to catch metrics regressions, rather than waiting until post-deploy. The test is straightforward: GET the metrics endpoint, confirm a few matches. More subtle is the reordering of the smoke test suite: the pd tests come last now, since the metrics will be empty on pd start, if no work has been performed. Refs #3780, #5004.
|
Tacked on a test to sanity-check the metrics emission, so we can catch this type of breakage in CI. Would have helped with the big version bumps recently. Confirmed that the new test fails on main, but passes here. |
conorsch
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Depends on penumbra-zone/cnidarium#9, let's just merge it once the release gets tagged and published. CI won't pass until then.
Issue ticket number and link
Fix #5004
Checklist before requesting a review
I have added guiding text to explain how a reviewer should test these changes.
Check
localhost:9000If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: