-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORS issues making requests from Buf Studio #3281
Comments
Try again. I've implemented CORS headers on the grpc service for testnet, but not (yet) for preview:
You should therefore be able to use Buf Studio with the testnet grpc, but not with preview grpc. Can you confirm? Once the CORS config is solid, I'll add a PR to this repo to make sure it's always added, so it'll stick around, even on preview re-deploys. |
Initial report shows working in Safari. I'm leaving this issue open as a reminder to update preview to match. |
Ensures that the ad-hoc changes made to the HTTPS reverse proxy fronting the pd gRPC services persist. We want to ensure that the pd gRPC services is usable with https://buf.build/studio/, and now it is. Refs #3281.
Ensures that the ad-hoc changes made to the HTTPS reverse proxy fronting the pd gRPC services persist. We want to ensure that the pd gRPC services is usable with https://buf.build/studio/, and now it is. Refs #3281.
Headers are serving:
via automatic deploy in https://github.com/penumbra-zone/penumbra/actions/runs/6777204344 |
We don't want to special-case Buf Studio, we want GRPC to work from arbitrary web contexts. |
Ah, I misunderstood. In that case, we'll want:
Which seems to have decent support cross-browser. |
This is still broken. Steps to reproduce:
We can't fix this by special casing for Buf studio specifically or for the testnet infrastructure Penumbra Labs happens to run. The node software has to work out of the box. |
We want to enable use of pd's gRPC services in arbitrary web contexts, including between localhost and a published website, for debugging. Refs #3281.
We want to enable use of pd's gRPC services in arbitrary web contexts, including between localhost and a published website, for debugging. Refs #3281.
We want to enable use of pd's gRPC services in arbitrary web contexts, including between localhost and a published website, for debugging. Refs #3281.
We want to enable use of pd's gRPC services in arbitrary web contexts, including between localhost and a published website, for debugging. Refs #3281.
OK, we should be good to go here. I've added CORS support inside |
Describe the bug
CORS issues prevent Buf studio from making requests to the GRPC endpoints.
To Reproduce
https://buf.build/studio/penumbra-zone/penumbra/main/penumbra.core.component.shielded_pool.v1alpha1.QueryService/DenomMetadataById?target=https%3A%2F%2Fgrpc.testnet.penumbra.zone&selectedProtocol=grpc-web&share=swqq5lJQUEosLk4t8UxRslIAcYECmXl5qUVArpJHuJFroXFoVFiwU0lJfmh5aKa%2Bb2iJq3lRkVFoqLl%2BqIepgUFSZYG5v2OyrRJQby1XLQA
Fails in Firefox and iOS safari
Expected behavior
Making requests should just work
The text was updated successfully, but these errors were encountered: