feat(#385): portfolio positions #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VanishMax
commented
Mar 7, 2025
Comment on lines
+16
to
+21
| /** Helper function that allows breaking early when using stream responses */ | ||
| async function* limitAsync<T>( | ||
| iterable: AsyncIterable<T>, | ||
| limit: number, | ||
| offset: number, | ||
| ): AsyncIterable<T> { |
There was a problem hiding this comment.
this function replaces basic Array.fromAsync and breaks early if the limit is reached, thus reducing calculations
| import { bech32mPositionId } from '@penumbra-zone/bech32m/plpid'; | ||
| import { queryClient } from '@/shared/const/queryClient'; | ||
| import { AddressIndex } from '@penumbra-zone/protobuf/penumbra/core/keys/v1/keys_pb'; | ||
|
|
||
| const BASE_LIMIT = 20; |
There was a problem hiding this comment.
if you want to play with the infinite scroll, reduce this limit
Comment on lines
+204
to
+210
| export const getDisplayPositions = ({ | ||
| positions, | ||
| getMetadataByAssetId, | ||
| asset1Filter, | ||
| asset2Filter, | ||
| stateFilter, | ||
| }: GetDisplayPositionsArgs): DisplayPosition[] => { |
There was a problem hiding this comment.
refactored the arguments of this function – now it accepts filters. By default, returns all positions
| </div> | ||
|
|
||
| {(isLoading ? loadingArr : sortedPositions).map((position, index) => ( | ||
| <Fragment key={`${position.idString}${index}`}> |
There was a problem hiding this comment.
Nitpick: You don't need to do this btw, keys only have to be unique for each loop. So index is enough here incase we have multiple positions with the same idString.
JasonMHasperhoven
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #385
In this PR:
usePathMetadatahook to get base and quote assets and later filter positions based on this. Also, it relied on thepositionsStorethat was difficult to scale and reuse in different pages. During this refactoring, I split the store into independent functions and moved them to the newentitiesfolder based on feature-sliced conventions.TableUI component toTableCell, and from table to grids – it allowed simpler multi-order positions rendering