fix: market buy and sell UI bugs #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vacekj
force-pushed
the
196-market-buy-and-sell-ui-bugs
branch
from
e3582b7 to
7e667ea
Compare
that was a generic choice of words, I should have been more specific when pointing out UI flaws. Notice the residual zero that cannot be cleared and overlapping elements. 
|
|
@cronokirby mentioned a bug fix with the duplicate amounts fixed via tailwind in the limit order PR: https://github.com/penumbra-zone/dex-explorer/pull/181/files#diff-ddaa81217b5d8d1ea37b43fe8b6feafcb0c8949ebf9a10806676c3f49acb6075R75 |
|
In that case, I think we are safe to land this before Limit orders, which might take more time. |
TalDerei
approved these changes
Dec 18, 2024
…asset amounts # Conflicts: # src/pages/trade/ui/order-form/order-form-market.tsx
vacekj
force-pushed
the
196-market-buy-and-sell-ui-bugs
branch
from
7e667ea to
390c851
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #196
@TalDerei can you please clarify what you meant by your last point in the issue (misplaced elements leading to inconsistent visual alignment)?