This repository was archived by the owner on Apr 10, 2025. It is now read-only.
fix: routebook visual updates #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
vacekj
force-pushed
the
146-route-book-updates
branch
from
2ecb06b to
b380629
Compare
VanishMax
suggested changes
Dec 6, 2024
There was a problem hiding this comment.
Ran the app, found some visual issues:
- Column "total" misalignment – the number should be aligned with the right side of a cell
- Columns go out of the screen, "route" column doesn't fit.
- Hops amount takes multiple lines
- It seems like the background doesn't fully fit the hovered row (last screen, in the bottom of it there's a black line that shouldn't be there)
|
@VanishMax apologies - it seems I pushed a botched up version, working on a fix now. |
…ons in trade components - Replaced static loading placeholders with a reusable Skeleton component for better consistency in the RouteBook. - Adjusted table header padding for improved alignment. - Introduced formatPrice and formatNumber functions to standardize price and number formatting across TradeRow and RouteBook components. - Updated TradeRow to utilize new formatting functions for displaying prices, amounts, and totals.
vacekj
force-pushed
the
146-route-book-updates
branch
from
b380629 to
794cec1
Compare
VanishMax
approved these changes
Dec 9, 2024
TalDerei
pushed a commit
to penumbra-zone/web
that referenced
this pull request
Mar 10, 2025
…issues/187) * fix: padding in route book * refactor: update skeleton loading rows and format price/number functions in trade components - Replaced static loading placeholders with a reusable Skeleton component for better consistency in the RouteBook. - Adjusted table header padding for improved alignment. - Introduced formatPrice and formatNumber functions to standardize price and number formatting across TradeRow and RouteBook components. - Updated TradeRow to utilize new formatting functions for displaying prices, amounts, and totals. * feat: almost there * fix: no more tables, grid is king * fix: lints * fix: lints
TalDerei
pushed a commit
to penumbra-zone/web
that referenced
this pull request
Mar 25, 2025
* fix: padding in route book * refactor: update skeleton loading rows and format price/number functions in trade components - Replaced static loading placeholders with a reusable Skeleton component for better consistency in the RouteBook. - Adjusted table header padding for improved alignment. - Introduced formatPrice and formatNumber functions to standardize price and number formatting across TradeRow and RouteBook components. - Updated TradeRow to utilize new formatting functions for displaying prices, amounts, and totals. * feat: almost there * fix: no more tables, grid is king * fix: lints * fix: lints
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #146