Limit Orders

[JasonMHasperhoven]

No description provided.

[hdevalence]

Running locally I get summary issues -- I think this was already fixed in main, do we think it would disappear on rebase?

[cronokirby]

Running locally I get summary issues -- I think this was already fixed in main, do we think it would disappear on rebase?

I got this error when I forgot to set the environment variable to point at a node

[erwanor]

Let's prefer using $p_1$ and $p_2$, we realized $p,q$ was messy too late in the implementation lifecycle, but we can still correct course here

[erwanor]

Do we need scale at all?

// Pseudo code
const p_1 = round(quoteAssetExponent * price);
const p_2 = baseAssetExponent;

[erwanor]

I don't understand the exponent shift.

[erwanor]

I think we need to make sure that base is asset_1 and quote is asset_2 and flip everything if it's not.

Ideally, there's a Position constructor that does this on your behalf so that you don't have to worry about it.

[hdevalence]

Some things I tested but couldn't get working:

1. Go to https://localhost/trade/USDY/USDC, try to create a "buy" limit order to buy 1 USDY @ 1:1 using 1 USDC. this fails with a negative exponent error

2. Same page, opposite direction, try to create a "sell" limit order to sell 1 USDC @ 1:1. this fails first with a missing source field (was undefined, pushed a commit that works around though i'm not sure it's the right approach), then I got an error that I didn't have any USDY. Reserves don't look correct to me, but I'm not sure why?

USDY/USDC limit orders are a good test case because they exercise different denoms and also unlock a market-based solution to the USDC transfer issue.

[cronokirby]

I refactored the stores to all have a much more consistent set of transitions and a reduced set of truth, and everything now seems to be working correctly.

I clobbered some work in the process, which is backed up in https://github.com/penumbra-zone/dex-explorer/tree/limitorders-archive just in case.

There were a handful of bugs not even reported in slack across the various forms, but now it should all work.

I tested it buy working on the testnet, using TestUSD and UM, which have 1e18 and 1e6 as the exponent

Range Liquidity:


The amount of um and test usd being consumed is right on the website, but also in the extension. Also, the base unit price is 1.7e12 in the first screenshot, which is accurate, given the exponent difference.

Limit Order
Buy


Sell

Some testing on mainnet would be appreciated

[JasonMHasperhoven]

We have arrived:
https://github.com/user-attachments/assets/f5a85d5f-202d-48af-92a6-e3c196c7ca82

[grod220]

Great job (everyone)! Given the number of devs that have contributed to this PR, think we should feel confident to ship and iterate as needed in follow ups 👍