Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

larva-patterns - Adds new kicker image support to the article kicker module. #873

Merged
merged 3 commits into from
Nov 19, 2024
Merged

larva-patterns - Adds new kicker image support to the article kicker module. #873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0f27e9
larva-patterns - Adds new kicker image support to the article kicker …
marcagarcia Nov 18, 2024
46e0e93
unpublished changelog update
marcagarcia Nov 18, 2024
b626036
Fix twig conditional to work with our parser.
marcagarcia Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Unpublished Changes
* larva-patterns - Adds new kicker image support to the article kicker module.

## 1.66.4 11-05-2024
* Remove Helvetica Fallback Fonts from body font in Rollingstone 2022
Expand Down
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ important information.
Clone this repository then, from the root, run the following commands:

```
nvm use
sh scripts/install-dependencies.sh
```

Expand Down
1 change: 1 addition & 0 deletions packages/larva-patterns/modules/article-kicker/article-kicker.prototype.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@ module.exports = {
article_kicker_text: 'Article Kicker',
article_kicker_url: '#',
article_kicker_link_classes: '',
article_kicker_image_markup: '',
};
12 changes: 8 additions & 4 deletions packages/larva-patterns/modules/article-kicker/article-kicker.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,15 @@
{% if article_kicker_url %}
<a href="{{ article_kicker_url }}" class="article-kicker-link {{ article_kicker_link_classes }}">
{% endif %}
{% if c_svg %}
{% include "@larva/components/c-svg/c-svg.twig" with c_svg %}
{% if article_kicker_image_markup %}
{{ article_kicker_image_markup }}
{% else %}
{{ article_kicker_text }}
{% endif %}
{% if c_svg %}
{% include "@larva/components/c-svg/c-svg.twig" with c_svg %}
{% else %}
{{ article_kicker_text }}
{% endif %}
{% endif %}
{% if article_kicker_url %}
</a>
{% endif %}
Expand Down
Loading