Update Fallback Fonts from sans-serif to serif in Rollingstone 2022 #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for pmc-larva ready! ✅ Preview Built with commit 50e23d7. |
rsalvucci
reviewed
Oct 31, 2024
| @@ -4,6 +4,9 @@ All notable changes to this project will be documented in this file. | |||
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
| and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | |||
|
|
|||
| ## 1.66.3 10-28-2024 | |||
| * Update Fallback Fonts from sans-serif to serif in Rollingstone 2022 | |||
|
|
|||
There was a problem hiding this comment.
This should go under the unplublished changes heading.
There was a problem hiding this comment.
@rsalvucci I didn't see this comment but ended up fixing it in the release branch
rsalvucci
approved these changes
Oct 31, 2024
JordanPak
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the token configuration to use serif as the fallback font instead of sans-serif. The purpose of this change is to improve readability and visual consistency in cases where custom fonts are unavailable or fail to load.
Bug
https://www.bugherd.com/projects/411027/tasks/815
Make sure you complete these items:
Unpublishedsectionnpm run prodin this repo outputs expected changes (excepting the issue with re-ordered partials in larva-css algorithms partials - see LRVA-1885)prod,lint, anddevscripts run as expected