Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to play generic iframe video #862

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Add support to play generic iframe video #862

merged 1 commit into from
Sep 11, 2024

Conversation

vtellapmc
Copy link
Collaborator

@vtellapmc vtellapmc commented Sep 11, 2024

Make sure you complete these items:

  • Updated root CHANGELOG.md with summary of changes under Unpublished section
  • npm run prod in this repo outputs expected changes (excepting the issue with re-ordered partials in larva-css algorithms partials - see LRVA-1885)
  • If adding a new pattern, in the PR comment, included a screenshot and link to the static Vercel deployment
  • If changes to build scripts or the Node.js server, tested changes in pmc-spark via a pre-release
    • If changes to build tools: npm scripts prod, lint, and dev scripts run as expected
    • If changes to Larva server: Static site generates as expected in a theme (avail. on a URL {brand}.stg.larva.pmcdev.io)

Copy link
Contributor

github-actions bot commented Sep 11, 2024

Deploy preview for pmc-larva ready!

✅ Preview
https://pmc-larva-8eb3zuwy9-penske-media-corp.vercel.app

Built with commit 2688d17.
This pull request is being automatically deployed with vercel-action

@vtellapmc vtellapmc force-pushed the feature/TG-99 branch 2 times, most recently from 0498584 to 44bc0a6 Compare September 11, 2024 17:26
@vtellapmc vtellapmc marked this pull request as ready for review September 11, 2024 17:32
@vtellapmc vtellapmc merged commit 8d35675 into master Sep 11, 2024
3 checks passed
@vtellapmc vtellapmc deleted the feature/TG-99 branch September 11, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants