Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new colors to Deadline. #854

Merged
merged 3 commits into from
Jul 1, 2024
Merged

Adding new colors to Deadline. #854

merged 3 commits into from
Jul 1, 2024

Conversation

richhaynie
Copy link
Contributor

@richhaynie richhaynie commented Jun 27, 2024

Make sure you complete these items:

  • Updated root CHANGELOG.md with summary of changes under Unpublished section
  • npm run prod in this repo outputs expected changes (excepting the issue with re-ordered partials in larva-css algorithms partials - see LRVA-1885)
  • If adding a new pattern, in the PR comment, included a screenshot and link to the static Vercel deployment
  • If changes to build scripts or the Node.js server, tested changes in pmc-spark via a pre-release
    • If changes to build tools: npm scripts prod, lint, and dev scripts run as expected
    • If changes to Larva server: Static site generates as expected in a theme (avail. on a URL {brand}.stg.larva.pmcdev.io)

Copy link
Contributor

github-actions bot commented Jun 27, 2024

Deploy preview for pmc-larva ready!

✅ Preview
https://pmc-larva-jol8vtv8j-penske-media-corp.vercel.app

Built with commit 3cbbdb0.
This pull request is being automatically deployed with vercel-action

@rsalvucci rsalvucci marked this pull request as ready for review July 1, 2024 13:42
@rsalvucci rsalvucci merged commit 4c76f9c into master Jul 1, 2024
3 checks passed
@rsalvucci rsalvucci deleted the feature/BR-3408 branch July 1, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants