Split into application and library #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the autotools configure.ac and cleanup the .gitignore file. While on it update the README.rst to include the required compile steps and provide a version bump. Signed-off-by: LI Qingwu <[email protected]> Signed-off-by: Marco Felsch <[email protected]>
The warning was detected with GCC 14.1.1 Signed-off-by: Marco Felsch <[email protected]>
Limit the scope to the current file. Signed-off-by: Marco Felsch <[email protected]>
Move struct modeset_dev declaration to the file top to make it easier to find it. This aligns the code more to the kernel coding style. Signed-off-by: Marco Felsch <[email protected]>
Introduce struct platsch_ctx to bundle the required state. At the moment it is just an container for the modeset_dev list but it will be extended in the upcoming commits. This commit also drops the usage of the gloabl modeset_list variable usage. Signed-off-by: Marco Felsch <[email protected]>
Save the drmfd file descriptor within the platsch_ctx and make use of it. This prepares the code base for the upcoming application/library split. Signed-off-by: Marco Felsch <[email protected]>
Store the dir path and base name within the platsch_ctx. The strdup() is not needed at the moment but prepares the code for the application/library split too. Signed-off-by: Marco Felsch <[email protected]>
Emantor
approved these changes
Aug 1, 2024
michaelolbrich
requested changes
Aug 2, 2024
pH5
reviewed
Aug 2, 2024
added 5 commits
August 5, 2024 10:56
Add platsch_create_ctx() to bundle the initialization. This prepares the code base for the upcoming application/library split. Signed-off-by: Marco Felsch <[email protected]>
Add platsch_draw() to bundle the draw step. This prepares the code base for the upcoming application/library split. Signed-off-by: Marco Felsch <[email protected]>
Add platsch_destroy_ctx() to bundle the final step. While on it add the missing modeset_dev free which is important once we split this part into a library. This prepares the code base for the upcoming application/library split. Signed-off-by: Marco Felsch <[email protected]>
Move the default value handling out of the application main() function into platsch_init_ctx(). This prepares the code base for the upcoming application/library split. Signed-off-by: Marco Felsch <[email protected]>
Use calloc which set the memory automatically to zero to remove the memset() call. Signed-off-by: Marco Felsch <[email protected]>
bith3ad
force-pushed
the
topic/libsplit
branch
2 times, most recently
from
21a583f
to
df275ae
Compare
| sources : ['libplatsch.c'], | ||
| dependencies : [libdrm_dep], | ||
| install : true | ||
| ) |
There was a problem hiding this comment.
You're creating a shared library here, right? In that case, we should probably export symbols properly.
There was a problem hiding this comment.
Yes, I addressed this with the latest version. Can you please check if my implementation is what you had in mind?
There was a problem hiding this comment.
$ nm -D libplatsch.so.0.1
[...]
00000000000029a1 T platsch_alloc_ctx
000000000000293e T platsch_create_ctx
0000000000002bb0 T platsch_destroy_ctx
000000000000276a T platsch_draw
0000000000002b96 T platsch_init_ctx
000000000000290a T platsch_register_custom_draw_cb
[...]
Looks good.
added 9 commits
August 7, 2024 09:31
Split the single platsch.c into platsch.c and libplatsch.c. The later can be used by other projects to build custom bootsplash applications once we support building the library. During the split no changes are made except for making: struct platsch_ctx *platsch_create_ctx(const char *dir, const char *base); void platsch_destroy_ctx(struct platsch_ctx *ctx); void platsch_draw(struct platsch_ctx *ctx); public. Signed-off-by: Marco Felsch <[email protected]>
This adds the support for building platsch and libplatsch. Platsch uses the static library to not cause any performance regression. By this commit the conversion from a standalone application into an application and library is complete. Signed-off-by: Marco Felsch <[email protected]>
Add drmIsMaster() before dropping the master to not cause confusion due to the error message print. Signed-off-by: Marco Felsch <[email protected]>
The platsch_create_ctx() allocates and init the ctx in one call but sometimes applications need to add custom data in between both steps. Therefore add platsch_alloc_ctx and platsch_init_ctx. Signed-off-by: Marco Felsch <[email protected]>
This adds the support to register a custom draw operation callback which will be called during platsch_draw(). The callback has all the necessary information about the framebuffer and a reference to the framebuffer itself to update content. The information will be freed after the callback has finished, therfore the content needs to be copied by the application. Signed-off-by: Marco Felsch <[email protected]>
Disable the setmode flag once it was set succefully since all further platsch_draw() calls only need an page flip operation. Signed-off-by: Marco Felsch <[email protected]>
Rename the function to platsch_draw_buffer and align the function params to make it identical to the platsch_custom_draw_buffer function. Signed-off-by: Marco Felsch <[email protected]>
Pass the whole contect to the helper function to align it with the code base. No functional change. Signed-off-by: Marco Felsch <[email protected]>
At the moment we rely on the 'default' visibility which was okay since all global functions are API functions. This is error prone as one could expose symbols by accident. Therefore change the behavior by setting the default visibility to 'hidden' and introducing a new macro to export selected API functions. Signed-off-by: Marco Felsch <[email protected]>
|
michaelolbrich
approved these changes
Aug 7, 2024
|
Successfully tested the pid1 and !pid1 use-case, ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this splits the single application into an application and library. It is based on the leica patch but is more traceable and don't expose internals to the library users instead a cookie solution is implemented.