-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#444 Switch to 'stable' rust toolchain channel #463
Conversation
53f3237
to
c2139da
Compare
explain why test has to use `+nightly`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍 A bit annoying that here we again have to do some extra handling for nightly due to the mocktopus crate but doing it this way is probably easier than refactoring the code to remove the mocktopus crate entirely. And in the future we might encounter other crates that we want to have in tests but need nightly so IMO it's okay to have this stable vs nightly setup you added @b-yap.
Closes #444.
There is a problem with using the Rust
nightly-2024-02-09
:I tried a lower version (
nightly-2023-12-28
) but errors still abound:Found this comment to choose a newer version, so I picked
nightly-2024-04-18
.How to begin the review:
action.yml
is a must. See documentation:cargo check
with stable versioncargo test
with nightly version1.77.0