-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update amplitude runtime to support XCM reserve transfer for USDT #290
update amplitude runtime to support XCM reserve transfer for USDT #290
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding my requested changes @b-yap.
While at first, it might seem like there is still some code that can be deduplicated, I think it's good the way it is right now. For example, some parameters like the IDs are shared between the Polkadot and Kusama asset hub, but still have separate definitions in runtime/common/src/lib.rs
but I think it's better this way because we can't necessarily always assume that this is the case. There could have been differences since the Polkadot and Kusama AssetHub are different parachains after all.
LGTM
83c56da
to
ad1ad33
Compare
The previous CI already passed and we only added comments so I will merge it without waiting. |
Closes task #83
General overview of the changes:
Aside from the tasks mentioned in the ticket, this PR also includes:
runtime/integration-tests/pendulum
toruntime/integration-tests
[dev-dependencies]
(see the updatedCargo.toml
)setup.rs
andpolkadot_test_net.rs
intomock.rs
test_macros.rs
tests.rs
to 2:pendulum_tests.rs
andamplitude_tests.rs
note: Statemint and Statemine have different issued balances, after performing
XTokens::transfer()
in Pendulum and Amplitude. See line 454 to 456 intest_macros.rs
.