-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bitmap Coloring layer version 2, with preview for scanned drawings #1178
base: master
Are you sure you want to change the base?
Conversation
I have updated this feature so it is more logical and user friendly.
I have removed the WIP. This is ready for review. |
Her is a 10 minute video, where I show how three scanned drawings end up like three beautiful colored animation frames. New changes are shown. |
Nice job! 🎉 This is certainly a great step forwards as many exciting opportunities will open just by adding the current feature. Once this is reviewed and merged I'm hoping other contributors will be interested in bringing back and expanding the color layer "bleed" feature for the fill tool. I'm sure such tool will synergize well with this coloring feature, allowing the user to color selected target layers automatically by using a a specific layer as an alpha mask reference, such as a lineart layer would be very interesting 👍 Similarly if and when we manage to also get back the fill expand feature the old Pencil used to have, people will be able to color depending on their preferred workflow: either with separate layers like the current implementation or on the same layer without halo artifacts as seen in opentoonz or retas paintman. Another path of future improvement that will hopefully come once this PR is merged is the automatization of the blending feature, particularly when using the fill tool on color traced drawings to fill highlight and shadow areas directly (i.e color traces). Either way thank you for opening so many potential doors for enhancement! Once again great job 🙌 😄 |
Thanks @Jose-Moreno. Yes, the feature has been improved, and is maybe more logical now, where you prepare your drawings first, and then use the coloring feature. Your old wish for the color bleed and expand feature is not forgotten. The last week I've had many debug sessions with CandyFace, and one thing we talked about (while waiting for compilation) was this feature. If you look at the drawings used in my video, these drawings could easily have been colored with the bleed/expand coloring. My coloring is mainly necessary if you have shadows, highligths and the like. |
I have made some changes based on the response I've got so far, so here is version 2 of the bitmap coloring feature.
A new video can be seen here.
I look forward to hear comments and suggestions for improvements.