Use reflect.Value.IsZero for omitempty checks#989
Closed
NathanBaulch wants to merge 1 commit intopelletier:v2from
Closed
Use reflect.Value.IsZero for omitempty checks#989NathanBaulch wants to merge 1 commit intopelletier:v2from
NathanBaulch wants to merge 1 commit intopelletier:v2from
Conversation
Owner
|
My apologies for the very long response delay. I think we should follow encoding/json and support a |
Owner
|
Closing because #998 is merged now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Struct fields of type
time.Timeandnetip.Addrare always omitted when usingomitemptybecause the currentisEmptyValuefunction can only check structs with exported fields. See #955 and #988.Replacing the current
isEmptyValuefunction withreflect.Value.IsZero()is a very simple and low risk fix that should makeomitemptyuseful for many more types.All the other measurements were equal.