Add errorcontext to unmarshalString() #856
Conversation
| ctx := d.errorContext | ||
| if ctx != nil && ctx.Struct != nil { | ||
| f := ctx.Struct.FieldByIndex(ctx.Field) | ||
| return unstable.NewParserErrorWithContext(d.p.Raw(value.Raw), "cannot store TOML string into struct field %s.%s of type %s", f.Name, f.Type, v.Kind()) |
There was a problem hiding this comment.
Unless I missed something, you should be able to use d.typeMismatchError() to generate an error that resulted from a mismatch between the expected Go type and the type found in the TOML document. It will take care of creating the human readable error based on whether the decoder is targeting a struct.
There was a problem hiding this comment.
Hey @pelletier,
Pardon my ignorance. I'm a newbie. Is there a way to get a human-readable error string when the type of a field mismatches? d.typeMismatchError() is internal, and I can't use it in my code. And, DecodeError.String() is multi-line, which is not something I want.
This is what I'm trying:
If my config looks like this,
[server]
path = "/my/path"
port = 50
and, I read it like this,
if err := toml.NewDecoder(file).Decode(&cfg); err != nil {
return Cfg{}, fmt.Errorf("load toml: %w", err)
}
I'm getting the error message load toml: cannot store TOML string into a Go int when the port is set to a string. How can I get the error message to mention the field server.port that is causing the problem?
There was a problem hiding this comment.
@arkn98 sorry I didn't see this. You're doing it right; the error message should contain the name of the field causing problem. Seems like this specific error is not constructed properly to include it.
There was a problem hiding this comment.
No worries at all. Your fix seems to work. Let me test it out. Thanks for looking into this!
|
@Krishks369 @arkn98 This should now be fixed by #891. Feel free to reopen this PR or create an issue if not! |
This PR tries to solve the issue here
@pellitier I have added the error context to the function according to my knowledge and please do check if its correct. Also can you provide a way to test it if its correct. Thanks for the reply