fix SPIFFS_readdir setting errno to SPIFFS_VIS_END at the end of iteration #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When iteration finishes, spiffs_obj_lu_find_entry_visitor returns SPIFFS_VIS_END. Previously, SPIFFS_readdir function used to set errno to this internal error value when readdir reached the end. Handle this case and add a check into the regression test.
|
@pellepl Do you have some time to review this one-liner fix? Thanks in advance! |
|
Absolutely! Thanks |
espressif-bot
pushed a commit
to espressif/esp-idf
that referenced
this pull request
Jun 11, 2022
See pellepl/spiffs#288 for the description of the issue. Reported in esp-rs/rust#117 (comment)
espressif-bot
pushed a commit
to espressif/esp-idf
that referenced
this pull request
Jul 4, 2022
See pellepl/spiffs#288 for the description of the issue. Reported in esp-rs/rust#117 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When iteration finishes,
spiffs_obj_lu_find_entry_visitorreturnsSPIFFS_VIS_END. Previously,SPIFFS_readdirfunction used to seterrnoto this internal error value when readdir reached the end.Handle this case and add a check into the regression test.
(Original issue: esp-rs/rust#117 (comment))