url function around static resource links (FILAMENT) #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrapped the static resource links in the url function to make it sync to APP_URL This would allow later on to support running in an subfolder *Filament version, with fix for livewire*
Miniontoby
changed the title
|
Oke, yeah someone needs to lint the branch... but I don't want to do it in here... |
|
Thank you for your contribution. I understand where you're coming from, but in short there's a more than this in the list of reasons why this app simply won't work in a sub directory. We won't be able to support that in the mean time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapped the static resource links in the url function to make it sync to APP_URL
This would allow later on to support running in an subfolder
Filament version, with fix for livewire