Support HTTPS or HTTP service URLs #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangejulius
force-pushed
the
https-support
branch
2 times, most recently
from
8569032 to
97aa414
Compare
orangejulius
force-pushed
the
https-support
branch
from
97aa414 to
f07e7af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the recommended configuration for Pelias has used HTTP communication between services, there are many valid reasons to put each service behind HTTPS.
Because of Node.js's interesting decision to have completely separate and incompatible
httpandhttpsmodules, this has not been a supported configuration out of the box.However, adding this support is not difficult, and that's what's been done here. Both HTTP and HTTPS service URLs should work seamlessly now.
Fixes pelias/pelias#839