Add maintainer info to Docker image via label #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was previously found only in the pelias/api image, but it should be everywhere.
orangejulius
added a commit
to pelias/api
that referenced
this pull request
Sep 4, 2018
This is enabled by the work in pelias/docker-baseimage#2 and lets us ensure the API is run as a non-root user. Additionally the maintainer label is now set in the baseimage as of (pelias/docker-baseimage#8), so it can be removed here.
orangejulius
added a commit
to pelias/api
that referenced
this pull request
Sep 7, 2018
This is enabled by the work in pelias/docker-baseimage#2 and lets us ensure the API is run as a non-root user. Additionally the maintainer label is now set in the baseimage as of (pelias/docker-baseimage#8), so it can be removed here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously found only in the pelias/api image, but it should be everywhere.
I wasn't sure if labels propagate to images that are built on other images, but after some testing it appears that they do.