Upgrade Node.js to version 10.13.0 (LTS) #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
missinglink
approved these changes
Oct 29, 2018
orangejulius
force-pushed
the
nodejs10
branch
from
ddf4c74
to
f6a7a22
Compare
orangejulius
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm planning on merging this after 10.13.0 is released in a few days, and v10.0 becomes the LTS, recommended for production version of Node.js
We've been testing Node.js 10 quite a bit, up to and including full planet builds, and it's at least a little bit faster. JSON parsing seems especially faster, which is often a bottleneck for Pelias.
This is the PR to track in Node.js for when 10.13.0 is going to be released: nodejs/node#23831