Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor controller/markdownToHtml.js module #1599

Merged
merged 3 commits into from
Feb 2, 2022
Merged

refactor controller/markdownToHtml.js module #1599

merged 3 commits into from
Feb 2, 2022

Conversation

missinglink
Copy link
Member

authored by @Dhananjay-JSR this PR replaces #1598.

this PR makes several fixes:

  • reformat the output to serve valid HTML
  • use template literals to make the markdown and html code more legible.
  • use a standard HTML5 boilerplate with a DOCTYPE, TITLE etc.
  • remove the styleString variable and instead just write the style info inline in the <head><style>
  • clean up the controller code, removing the content negotiation code which wasn't being used
  • fix/clean up the unit test code.

Thanks to @Dhananjay-JSR for this contribution 🎉

resloves #1597

@missinglink missinglink changed the title Fixed mark down to html refactor controller/markdownToHtml.js module Feb 2, 2022
@missinglink missinglink merged commit 5c650df into master Feb 2, 2022
@missinglink missinglink deleted the Fixed_MarkDown_To_HTML branch February 2, 2022 12:20
This was referenced Feb 2, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@missinglink @Dhananjay-JSR