feat/rankings: optimize Steam ID comparison #236
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the Steam ID is a 64bit integer we should compare it in registers directly instead of comparing a string byte by byte. The string representation is only needed when constructing the URL to call the profile API and when exporting the data.
It's a µ-optimization so this does not speed up the program too much since the biggest slowdown will always be network requests.
Profiled this small code section: