rankings: fetch profiles faster and improvements #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* perf: batch 100 profiles at once since the Steam API allows that much * feat: --now/-n CLI flag to run once and exit * feat: --cache/-c CLI flag to cache leaderboards. Only works with --now * fix: automatically create output folder * fix: more logging so we know what is happening * refactor: removed double references where it did not make sense
|
Looks good to me. Thank you for your improvements! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
./rankings -n -cafter initial run without caching takes less than 10 seconds so that should be more convenient in testing.