Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental @oneof directive support for input types #1723

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Conversation

pekkah
Copy link
Owner

@pekkah pekkah commented Jan 11, 2024

No description provided.

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 58 lines in your changes are missing coverage. Please review.

Comparison is base (18f7269) 68.42% compared to head (9fa411d) 68.31%.

❗ Current head 9fa411d differs from pull request most recent head acc9e0a. Consider uploading reports for the commit acc9e0a to get more accurate results

Files Patch % Lines
src/GraphQL/Validation/ExecutionRules.cs 15.38% 19 Missing and 3 partials ⚠️
...QL.Extensions.Experimental/OneOf/OneOfDirective.cs 79.59% 4 Missing and 6 partials ⚠️
src/GraphQL.Server/WebSockets/ServerMethods.cs 0.00% 10 Missing ⚠️
....Experimental/OneOf/ServiceCollectionExtensions.cs 0.00% 4 Missing ⚠️
...ions.Experimental/OneOf/SchemaBuilderExtensions.cs 0.00% 2 Missing ⚠️
src/GraphQL.Server/GraphQLApplicationBuilder.cs 0.00% 2 Missing ⚠️
src/GraphQL.Server/WebSockets/ClientMethods.cs 0.00% 2 Missing ⚠️
src/GraphQL/ServiceCollectionExtensions.cs 75.00% 2 Missing ⚠️
src/GraphQL/TypeSystem/SchemaBuilder.cs 50.00% 2 Missing ⚠️
src/GraphQL.Language/Nodes/ObjectValue.cs 87.50% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1723      +/-   ##
==========================================
- Coverage   68.42%   68.31%   -0.11%     
==========================================
  Files         287      291       +4     
  Lines       11543    11638      +95     
  Branches     1519     1533      +14     
==========================================
+ Hits         7898     7951      +53     
- Misses       3201     3236      +35     
- Partials      444      451       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pekkah pekkah enabled auto-merge (squash) January 11, 2024 19:18
@pekkah pekkah merged commit 69eb84b into main Jan 11, 2024
5 checks passed
@pekkah pekkah deleted the feature/input-oneof branch January 11, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant