Fall back on console.log when node-inspect-extracted fails #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mingun
reviewed
Mar 9, 2023
| } | ||
| console.warn("node-util-inspect not supported on this browser") | ||
| console.log(obj) | ||
| return String(obj) + " // See browser console" |
There was a problem hiding this comment.
I think it would be better to swap hint and object representation, so the hint is always be visible in case of big objects
Suggested change
| return String(obj) + " // See browser console" | |
| return "// See browser console. Stringifyed result:\n" + String(obj) |
|
I decided to fix this in node-inspect-extracted after all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #371, but not really.