Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: error logging and version mismatches #94

Merged
merged 48 commits into from
May 19, 2023
Merged

Fix: error logging and version mismatches #94

merged 48 commits into from
May 19, 2023

Conversation

yusufuyanik1
Copy link
Collaborator

Health Check Set Up Article:

  • Added instruction to install quarto cli.

Pyproject.toml:

  • Plotly should be installed above a certain version, otherwise we were getting an error at TreeMap function. Entered the latest version. The rest is from previous PR.

App:

  • In healthcheck.py, I put everything after generatehealthcheck function in an exception block to make sure that if something fails, we get only one error with a clean message and creating log.txt file doesn't fail
  • At the end of the exception block, we delete every file created under healthcheckDir (workingdir). Previously, if the code failed before getting to delete_temp_files function, the temp files would remain.
  • If the code fails after creating the html file, we append the traceback to the present log.txt file

Tests:

  • I was getting polars DataFrame doesn't have frame property error. I believe using polars' built in assert_frame_equal function could be a good alternative.

yusufuyanik1 and others added 30 commits March 23, 2023 10:59
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.07 ⚠️

Comparison is base (b1d34d3) 73.55% compared to head (f7bf979) 73.48%.

❗ Current head f7bf979 differs from pull request most recent head 8916052. Consider uploading reports for the commit 8916052 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
- Coverage   73.55%   73.48%   -0.07%     
==========================================
  Files          19       19              
  Lines        2515     2516       +1     
==========================================
- Hits         1850     1849       -1     
- Misses        665      667       +2     
Impacted Files Coverage Δ
python/pdstools/adm/ADMDatamart.py 74.46% <0.00%> (-0.46%) ⬇️
python/pdstools/plots/plot_base.py 72.41% <ø> (-0.10%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@operdeck operdeck merged commit 41c8383 into pegasystems:master May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants