Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

series.cut() fix along with ADMExplained reproducibility improvement #111

Merged
merged 6 commits into from
Jul 25, 2023

Conversation

yusufuyanik1
Copy link
Collaborator

  • With the newest polars version(0.18.7) polars doesn't accept float("inf") as a bin of pl.Series.cut() function. (See the change in ADMDatamart.py, and the bin ordering change in plots_plotly related to that)
  • Slight refactor to auc_from_bins function to make it exactly the same as in the R version
  • Made ADMExplained reproducible.

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -22.60 ⚠️

Comparison is base (20848cd) 88.76% compared to head (815018d) 66.16%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #111       +/-   ##
===========================================
- Coverage   88.76%   66.16%   -22.60%     
===========================================
  Files           6       20       +14     
  Lines        1477     2793     +1316     
===========================================
+ Hits         1311     1848      +537     
- Misses        166      945      +779     
Impacted Files Coverage Δ
python/pdstools/adm/ADMDatamart.py 74.15% <ø> (ø)
python/pdstools/plots/plots_plotly.py 85.12% <100.00%> (ø)
python/pdstools/utils/cdh_utils.py 86.01% <100.00%> (ø)

... and 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yusufuyanik1 yusufuyanik1 changed the title series.cut() fix along with ADM robustness improvements series.cut() fix along with ADMExplained reproducibility improvement Jul 24, 2023
@operdeck operdeck merged commit 1171818 into pegasystems:master Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants