US-613462 Support adding WEB_XML_SNIPPET #224
Open
+102
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maracle6
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed solution for US-613462 and pegasystems/pega-helm-charts#577 which allows a user of the pega Helm chart to define an env variable WEB_XML_SNIPPET which will be inserted into the web.xml just before the tag. This allows users to:
Add an additional servlet
Add a security constraint
Add JMS resources
Without the snippet feature, the user needs to either embed an entire 1600+ line web.xml into their values file, or put a replacement web.xml into the config/deploy folder (which either means using local charts instead of hosting in a repository, or having to repackage every chart release with the customization).
This feature also pairs with the existing functionality we have for specifying a CONTEXT_XML_SNIPPET.