Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GRPH-54 sign_transaction fix (18.04) #78

Closed
wants to merge 2 commits into from
Closed

GRPH-54 sign_transaction fix (18.04) #78

wants to merge 2 commits into from

Conversation

ronakpatel3110
Copy link

No description provided.

@bobinson bobinson self-requested a review August 27, 2019 17:42
bobinson
bobinson requested changes Aug 27, 2019
View reviewed changes
Copy link

@bobinson bobinson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please start Gitflow from from develop branch
  2. Send the PR to develop

reference: https://www.atlassian.com/git/tutorials/comparing-workflows/gitflow-workflow

git checkout develop
git checkout -b feature/GRPH-54
git checkout develop
git merge feature/GRPH-54

or use git flow extention

@bobinson bobinson mentioned this pull request Aug 27, 2019
Closed
@bobinson bobinson added bug Something isn't working Changes Requested Changes Requested via review labels Aug 27, 2019
@ronakpatel3110
Copy link
Author

@bobinson This is already covered in #87 . This seems to be an outdated PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobinson bobinson bobinson requested changes

Assignees
No one assigned
Labels
bug Something isn't working Changes Requested Changes Requested via review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ronakpatel3110 @bobinson @obucina