[GRPH-81] Different performance optimization #116
Conversation
|
Also , this code doesn't change the functionality itself, so we can use existing |
The old bug is cryptonomex/graphene#615 . Due to the bug, `update_median_feeds()` and `check_call_orders()` will be called when a feed is not actually expired, normally this should not affect consensus since calling them should not change any data in the state. However, the logging indicates that `check_call_orders()` did change some data under certain circumstances, specifically, when multiple limit order matching issue (#453) occurred at same block. * bitshares/bitshares-core#453
* changed an `assert()` to `FC_ASSERT()` * replaced one `db.get(asset_id_type())` with `db.get_core_asset()` * capture only required variables for lambda
|
I've updated the state, re-review, please. |
|
From bitshares PR bitshares/bitshares-core@78ff14e is not included. Does is not apply for us ? |
|
@oxarbitrage , I don't sure that skipping this check is acceptable for Peerplays network, because we haven't details about the workers now.) I've thought that we can add this commit later, it is not criticaltical. But I can add it if you think we should apply it right now. |
|
I think we should add if we can so we will have the full PR from bitshares applied and will not have to get back later. Thanks. |
|
@oxarbitrage , I've added this commit, re-review, please. |
Backport of the Bitshares PR bitshares/bitshares-core#1180.
It adds several optimization:
update_expired_feedswith tracking of the expired rates;