Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove previous/next class only on items within current container #68

Merged
merged 1 commit into from
Aug 19, 2016

Conversation

Djules
Copy link
Contributor

@Djules Djules commented Jul 1, 2016

This commit fixes issue #55 when using multiple sliders on a page.

@peduarte peduarte self-assigned this Jul 13, 2016
@peduarte
Copy link
Owner

@Djules Thanks for this. Did you test all the examples in the example folder? I'm just thinking whether the change from querySelectorAll to querySelector could have broken something.

@Djules
Copy link
Contributor Author

Djules commented Jul 14, 2016

Didn't had a chance to test no, but querySelector() and querySelectorAll()[0] give the same result, isn't it?

@peduarte
Copy link
Owner

Yeah, I should do some tests before I merge this. I'll try and test this weekend, just to make sure everything is fine :)
Thanks!

@peduarte peduarte merged commit dec30c9 into peduarte:master Aug 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants