Add whitelist obj for elements with length #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,7 +29,12 @@ | |||
| carousel: true | |||
| }; | |||
|
|
|||
| if (selector.length > 0) { | |||
| // Whitelist elements which container `length` | |||
|
@henriquea did you test this? |
|
@peduarte are you joking right? works fine locally. You said zuul doesn't work with Travis and always fail? |
|
@henriquea alright, if you tested it then... i'll trust you. Can you fix the typo then ill merge, thanks |
|
Sure baby 💕 |
|
@henriquea <3 |
peduarte
pushed a commit
that referenced
this pull request
Aug 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lengthso wallop doesn't throw an error. Fixes Doesn't work for form elements #64