Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suspected Memory Leak #3

Closed
mtharrison opened this issue Nov 2, 2014 · 2 comments
Closed

Suspected Memory Leak #3

mtharrison opened this issue Nov 2, 2014 · 2 comments

Comments

@mtharrison
Copy link

This module seems to leak memory over time. I think it's down to the Timer.unref(), the Timers never seem to be GC'd.

Possibly related: nodejs/node-v0.x-archive#8364
@aheckmann
Copy link
Contributor

have you retested using the patch attached to that ticket?

jlai added a commit that referenced this issue Nov 25, 2014
@jlai
Workaround for #3 (memory leak in timer unref)
262dbfa 
Add clearTimeout() as a workaround for nodejs not cleaning up
unref()'d timers.
aheckmann added a commit that referenced this issue Nov 26, 2014
@aheckmann
Merge pull request #4 from pebble/unref-bug-workaround
d9923da 
Workaround for #3 (memory leak in timer unref)
@aheckmann
Copy link
Contributor

fixed in 1.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aheckmann @mtharrison