Skip to content

Allow - and . in log filenames. #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow - and . in log filenames. #347

wants to merge 1 commit into from

Conversation

@Spacerat
Copy link
Contributor

@Spacerat Spacerat commented Sep 2, 2016 •
edited
Loading

This PR fixes a bug where build/run log entries would not correctly link to files with with . or - in their names.

Before/after for build logs:
screen shot 2016-09-02 at 13 33 43
screen shot 2016-09-02 at 13 34 14
And run logs:
screen shot 2016-09-02 at 13 53 30
screen shot 2016-09-02 at 13 52 55

@pebble-heroku pebble-heroku temporarily deployed to cloudpebble-sp-pr-347 September 2, 2016 20:56 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Spacerat @pebble-heroku