PBL-31842 CloudPebble project settings incorrect after chrome restart #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spacerat
force-pushed
the
bugfix/forgetting-settings
branch
from
3ee6c82 to
a164ba3
Compare
Spacerat
force-pushed
the
bugfix/forgetting-settings
branch
from
a164ba3 to
50ae402
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Fixes #271)
When restoring pages after closing the browser, chrome sets form element values to their previous values. However, because of the way that CloudPebble pages work (HTML template cloning), the original form elements never appear to chrome to have actually changed. Thus, when reloading the page, chrome resets the values of things to whatever they were before they were changed.
The easy fix for Chrome is to add form.reset(), which sets all values back to their defaults.