Make the page number go between 1 and the last page number.#268
Open
Butanosuke wants to merge 1 commit intopeachananr:masterfrom
Open
Make the page number go between 1 and the last page number.#268Butanosuke wants to merge 1 commit intopeachananr:masterfrom
Butanosuke wants to merge 1 commit intopeachananr:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When updateURL is true and you scroll from top page to bottom page or in reverse direction, it shows non-existent page number after the hash mark.
The page number should be existent.
For example, let's assume that total number of pages was 3.
When current page number is 1 and you scroll to previous page then the page number becomes 0.
It should be 3.
When current page number is 3 and you scroll to next page then the page number becomes 4.
It should be 1.