Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump node16 to node20 #1067

Merged
merged 3 commits into from
Feb 14, 2024
Merged

chore: bump node16 to node20 #1067

merged 3 commits into from
Feb 14, 2024

Conversation

SukkaW
Copy link
Contributor

@SukkaW SukkaW commented Feb 2, 2024

Fixes #1062 by bumping to node20.

@SukkaW SukkaW changed the title chore: bump from nodejs16 to nodejs20 chore: bump from node16 to node20 Feb 2, 2024
@actions-gh-pages actions-gh-pages bot added the dependencies Pull requests that update a dependency file label Feb 2, 2024
@SukkaW
Copy link
Contributor Author

SukkaW commented Feb 8, 2024

@peaceiris

Just sending a friendly reminder since the PR hasn't been reviewed for about a week. Would you mind taking a look at it?

@gaby
Copy link

gaby commented Feb 14, 2024

@peaceiris Any chance of getting this merged?

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cdc09a3) 58.78% compared to head (a69d56f) 58.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1067   +/-   ##
=======================================
  Coverage   58.78%   58.78%           
=======================================
  Files           4        4           
  Lines         296      296           
  Branches       64       64           
=======================================
  Hits          174      174           
  Misses        119      119           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@peaceiris peaceiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much all!

@peaceiris peaceiris changed the title chore: bump from node16 to node20 chore: bump node16 to node20 Feb 14, 2024
@peaceiris peaceiris merged commit 4eb285e into peaceiris:main Feb 14, 2024
14 checks passed
@retyui
Copy link

retyui commented Feb 26, 2024

@peaceiris Are you going to release it?)

copybara-service bot pushed a commit to GoogleCloudPlatform/gcpdiag that referenced this pull request Mar 22, 2024
peaceiris/actions-gh-pages#1067

Fixes: 328630225
Change-Id: I10fcc9e017ba4a84189c7a3f8fa0f5a18cb66027
GitOrigin-RevId: 38c301c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cicd dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proposal: update node version to 20
5 participants