Prohibited branch detection does not work

[peaceiris]

Describe the bug

When users set a publish_branch that is the same as a branch triggered by the workflow, this action stops the deployment to protect the branch.

actions-gh-pages/src/set-tokens.ts

Lines 76 to 81 in e3404eb

	if (eventName === 'push') {
	isProhibitedBranch = ref.includes(`refs/heads/${publishBranch}`);
	if (isProhibitedBranch) {
	throw new Error(`You deploy from ${publishBranch} to ${publishBranch}`);
	}
	}

Currently, this protection behavior does not work.

To Reproduce

With peaceiris/actions-gh-pages@v3

on:
  push:
    branches:
      - master
...
          publish_branch: master

Expected behavior
This Action should return the error You deploy from master to master

Screenshots

Your YAML file

• A link to your repository: https://github.com/peaceiris/test-mdbook
• A link to your YAML file: https://github.com/peaceiris/test-mdbook/actions/runs/85307348/workflow
• A link to your workflow log: https://github.com/peaceiris/test-mdbook/runs/610595170?check_suite_focus=true#step:6:116

Additional context
I found this bug in this article: AsciidocのドキュメントをGitHub Actionsを用いてGitHub Pagesで公開する。 - Qiita

This protection should be also implemented for personal_token, deploy_key, and eventName === 'pull_request'.

[abedurftig]

@peaceiris, thanks for following up. I see my mistake. I think the README is clear now.

[peaceiris]

It works well now.

[github-actions]

This issue has been LOCKED because of it being resolved!

The issue has been fixed and is therefore considered resolved.
If you still encounter this or it has changed, open a new issue instead of responding to solved ones.

Log | Bot Usage