Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy triggered by scheduled event fails on v3.5.4 #157

Closed
sarisia opened this issue Mar 16, 2020 · 5 comments
Closed

deploy triggered by scheduled event fails on v3.5.4 #157

sarisia opened this issue Mar 16, 2020 · 5 comments
Assignees
Labels
bug Something isn't working resolved

Comments

@sarisia
Copy link
Contributor

sarisia commented Mar 16, 2020

Describe the bug
Latest release (v3.5.4) breaks workflow triggered by schedule event

To Reproduce
Steps to reproduce the behavior:

  1. make workflow scheduled:
on:
  schedule:
    - cron: '0 * * * *'
  1. it fails:
2020-03-16T01:15:53.7982119Z ##[group]Run peaceiris/actions-gh-pages@v3
2020-03-16T01:15:53.7982321Z with:
2020-03-16T01:15:53.7982726Z   github_token: ***
2020-03-16T01:15:53.7982877Z   publish_dir: ./public
2020-03-16T01:15:53.7983017Z   publish_branch: public
2020-03-16T01:15:53.7983205Z   keep_files: true
2020-03-16T01:15:53.7983349Z   commit_message: **********
2020-03-16T01:15:53.7983488Z   user_name: ************
2020-03-16T01:15:53.7983666Z   user_email: **********
2020-03-16T01:15:53.7983811Z   allow_empty_commit: false
2020-03-16T01:15:53.7983950Z   force_orphan: false
2020-03-16T01:15:53.7984087Z   enable_jekyll: false
2020-03-16T01:15:53.7984227Z   disable_nojekyll: false
2020-03-16T01:15:53.7984386Z env:
2020-03-16T01:15:53.7984561Z   pythonLocation: /opt/hostedtoolcache/Python/3.7.6/x64
2020-03-16T01:15:53.7984715Z ##[endgroup]
2020-03-16T01:15:53.9159901Z [INFO] GithubToken: true
2020-03-16T01:15:53.9160905Z [INFO] PublishBranch: public
2020-03-16T01:15:53.9161384Z [INFO] PublishDir: ./public
2020-03-16T01:15:53.9162009Z [INFO] ExternalRepository: 
2020-03-16T01:15:53.9162490Z [INFO] AllowEmptyCommit: false
2020-03-16T01:15:53.9163013Z [INFO] KeepFiles: true
2020-03-16T01:15:53.9163481Z [INFO] ForceOrphan: false
2020-03-16T01:15:53.9164126Z [INFO] UserName: ******
2020-03-16T01:15:53.9164866Z [INFO] UserEmail: ****************
2020-03-16T01:15:53.9165627Z [INFO] CommitMessage: ***********
2020-03-16T01:15:53.9166067Z [INFO] TagName: 
2020-03-16T01:15:53.9166461Z [INFO] TagMessage: 
2020-03-16T01:15:53.9166903Z [INFO] EnableJekyll (DisableNoJekyll): false
2020-03-16T01:15:53.9167392Z [INFO] CNAME: 
2020-03-16T01:15:53.9167758Z 
2020-03-16T01:15:53.9174090Z ##[error]Action failed with "Cannot read property 'fork' of undefined"

Expected behavior
deploy successfully

Your YAML file
https://github.com/sarisia/holodule-ics/actions/runs/56415538

Additional context
cause is:

const isForkRepository = (context.payload as any).repository.fork;

schedule event payload does not contain repository.

@sarisia sarisia added the bug Something isn't working label Mar 16, 2020
@peaceiris peaceiris pinned this issue Mar 16, 2020
@peaceiris
Copy link
Owner

Sorry. I will release a fixed version soon.

@sarisia sarisia changed the title deploy triggered by schedule event fails on v3.5.4 deploy triggered by scheduled event fails on v3.5.4 Mar 16, 2020
peaceiris added a commit that referenced this issue Mar 16, 2020
@peaceiris
Copy link
Owner

peaceiris commented Mar 16, 2020

#158 has been merged, v3.5.5 released, and the v3 tag updated.

cc: @corollari

@peaceiris
Copy link
Owner

peaceiris commented Mar 16, 2020

v3.5.6 has been released and the v3 tag updated.

@sarisia
Copy link
Contributor Author

sarisia commented Mar 16, 2020

It worked well. Thanks quick respond and fix!

@sarisia sarisia closed this as completed Mar 16, 2020
@peaceiris peaceiris unpinned this issue Mar 21, 2020
@github-actions
Copy link
Contributor

This issue has been LOCKED because of it being resolved!

The issue has been fixed and is therefore considered resolved.
If you still encounter this or it has changed, open a new issue instead of responding to solved ones.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working resolved
Projects
None yet
Development

No branches or pull requests

2 participants