Skip to content

chore: Bump reqwest from 0.12.3 to 0.12.4 (#281) #700

chore: Bump reqwest from 0.12.3 to 0.12.4 (#281)

chore: Bump reqwest from 0.12.3 to 0.12.4 (#281) #700

GitHub Actions / clippy succeeded Apr 22, 2024 in 0s

clippy

5 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 5
Note 0
Help 0

Versions

  • rustc 1.77.2 (25ef9e3d8 2024-04-09)
  • cargo 1.77.2 (e52e36006 2024-03-26)
  • clippy 0.1.77 (25ef9e3 2024-04-09)

Annotations

Check warning on line 99 in fatigue/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

deref which would be done by auto-deref

warning: deref which would be done by auto-deref
  --> fatigue/src/main.rs:99:47
   |
99 |         output_formatter.update_result_status(&*rx.borrow());
   |                                               ^^^^^^^^^^^^^ help: try: `&rx.borrow()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
   = note: `#[warn(clippy::explicit_auto_deref)]` on by default

Check warning on line 77 in fatigue/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

usage of an `Arc` that is not `Send` and `Sync`

warning: usage of an `Arc` that is not `Send` and `Sync`
  --> fatigue/src/main.rs:77:28
   |
77 |     let output_formatter = Arc::new(get_output_formatter());
   |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `Arc<Box<dyn OutputFormatter>>` is not `Send` and `Sync` as:
   = note: - the trait `Send` is not implemented for `Box<dyn OutputFormatter>`
   = note: - the trait `Sync` is not implemented for `Box<dyn OutputFormatter>`
   = help: consider using an `Rc` instead. `Arc` does not provide benefits for non `Send` and `Sync` types
   = note: if you intend to use `Arc` with `Send` and `Sync` traits
   = note: wrap the inner type with a `Mutex` or implement `Send` and `Sync` for `Box<dyn OutputFormatter>`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync
   = note: `#[warn(clippy::arc_with_non_send_sync)]` on by default

Check warning on line 158 in libfatigue/src/context/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

redundant closure

warning: redundant closure
   --> libfatigue/src/context/mod.rs:158:18
    |
158 |             .map(|a| StaticContextTracker::new(a))
    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `StaticContextTracker::new`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
    = note: `#[warn(clippy::redundant_closure)]` on by default

Check warning on line 43 in libfatigue/src/context/actions/json.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

returning the result of a `let` binding from a block

warning: returning the result of a `let` binding from a block
  --> libfatigue/src/context/actions/json.rs:43:21
   |
42 |                     let res = serde_json::from_str(raw.as_str())?;
   |                     ---------------------------------------------- unnecessary `let` binding
43 |                     res
   |                     ^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
   = note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
   |
42 ~                     
43 ~                     serde_json::from_str(raw.as_str())?
   |

Check warning on line 36 in libfatigue/src/actions/request.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

useless conversion to the same type: `std::str::Lines<'_>`

warning: useless conversion to the same type: `std::str::Lines<'_>`
  --> libfatigue/src/actions/request.rs:34:43
   |
34 |           let rendered_path_lines: Vec<_> = rendered_path
   |  ___________________________________________^
35 | |             .lines()
36 | |             .into_iter()
   | |________________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
   = note: `#[warn(clippy::useless_conversion)]` on by default
help: consider removing `.into_iter()`
   |
34 ~         let rendered_path_lines: Vec<_> = rendered_path
35 +             .lines()
   |