wip: Attempting to also build lix with nix-ninja#8
Draft
Conversation
Contributor
Author
|
Refactored non-lix related changes to: #8 |
Contributor
Author
|
Refactored example/nix/default.nix to: #29 |
mupdt
reviewed
Aug 27, 2025
| let mut path = relative_path.to_string_lossy().into_owned(); | ||
| canon::canonicalize_path(&mut path); | ||
|
|
||
| let canonical_path = fs::canonicalize(&path)?; |
Contributor
There was a problem hiding this comment.
You have 2 canonicalization calls here. Mind adding a comment to the code explaining why this is necessary?
mupdt
reviewed
Aug 27, 2025
| @@ -0,0 +1,98 @@ | |||
| { inputs | |||
Contributor
There was a problem hiding this comment.
Maybe use nix-src rather than the whole inputs attrset (the same for lix)?
Suggested change
| { inputs | |
| { nix-src |
mupdt
reviewed
Aug 27, 2025
Contributor
There was a problem hiding this comment.
Consider adding a postInstall step that verifies lix --help works, or something like that. Same for the nix example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not working yet, but there's also some bug fixes here that should be refactored out.