Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add safe_compatible version specifiers saving strategy #3314

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

tkzt
Copy link
Contributor

@tkzt tkzt commented Nov 26, 2024

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

To fix #3301.

Add one safe_compatible version specifiers saving strategy, which will pin version (let's say the version.micro is truthy) to ~={version.major}.{version.minor}.{version.micro}.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.32%. Comparing base (a3974f3) to head (f9fa3e3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3314      +/-   ##
==========================================
+ Coverage   85.31%   85.32%   +0.01%     
==========================================
  Files         112      112              
  Lines       11403    11406       +3     
  Branches     2488     2489       +1     
==========================================
+ Hits         9728     9732       +4     
+ Misses       1145     1144       -1     
  Partials      530      530              
Flag Coverage Δ
unittests 85.12% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frostming
Copy link
Collaborator

Nice PR. Thanks

@frostming frostming merged commit 2631439 into pdm-project:main Nov 27, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save strategy for ~=x.y.z
2 participants