Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdm_build.py added twice in sdist file. #250

Closed
Bing-su opened this issue Jul 15, 2024 · 0 comments ยท Fixed by #251
Closed

pdm_build.py added twice in sdist file. #250

Bing-su opened this issue Jul 15, 2024 · 0 comments ยท Fixed by #251
Assignees

Comments

@Bing-su
Copy link

Bing-su commented Jul 15, 2024

์Šคํฌ๋ฆฐ์ƒท 2024-07-15 135248

pip-binary-factory\pocketbase on ๎‚  main is ๐Ÿ“ฆ v0.22.17 via ๐Ÿน v1.22.5 via ๐Ÿ v3.12.3 (.venv) 
โฏ pdm --version
PDM, version 2.16.1

pip-binary-factory\pocketbase on ๎‚  main is ๐Ÿ“ฆ v0.22.17 via ๐Ÿน v1.22.5 via ๐Ÿ v3.12.3 (.venv) 
โฏ python -m build -s
* Creating virtualenv isolated environment...
* Installing packages in isolated environment... (pdm-backend, tomli; python_version < '3.11')
* Getting dependencies for sdist...
* Building sdist...
 - Adding LICENSE -> LICENSE
 - Adding README.md -> README.md
 - Adding build_wheel.py -> build_wheel.py
 - Adding download.nu -> download.nu
 - Adding fix.go -> fix.go
 - Adding go.mod -> go.mod
 - Adding go.sum -> go.sum
 - Adding main.go -> main.go
 - Adding pdm_build.py -> pdm_build.py
 - Adding pdm_build.py -> pdm_build.py
 - Adding .pdm-build\pyproject.toml -> pyproject.toml
 - Adding PKG-INFO -> PKG-INFO
Successfully built pocketbase_bin-0.22.17.tar.gz

I am distributing packages without python source files in a repository pip-binary-factory.

I discovered this while distributing the pocketbase-bin package: https://github.com/Bing-su/pip-binary-factory/tree/main/pocketbase

For now, I've fixed the issue by adding the file to the excludes, but you can reproduce the issue by fixing that part.

[tool.pdm.build]
is-purelib = false
source-includes = ["go.mod", "go.sum", "*.go", "download.nu"]
excludes = ["bin/*", ".gitignore", "pdm_build.py", "build_wheel.py"]

โ†“

[tool.pdm.build]
is-purelib = false
source-includes = ["go.mod", "go.sum", "*.go", "download.nu"]
excludes = ["bin/*", ".gitignore"]

Refer to this source code and the produced files.

pocketbase.zip (source code for reproduce)
pocketbase_bin-0.22.17.tar.gz (sdist file)

Thank you.

@frostming frostming self-assigned this Jul 15, 2024
frostming added a commit that referenced this issue Jul 15, 2024
frostming added a commit that referenced this issue Jul 16, 2024
erichesse referenced this issue in robert-koch-institut/mex-extractors Jul 23, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [pdm-backend](https://github.com/pdm-project/pdm-backend) |
build-system.requires | patch | `==2.3.2` -> `==2.3.3` |

---

### Release Notes

<details>
<summary>pdm-project/pdm-backend (pdm-backend)</summary>

###
[`v2.3.3`](https://github.com/pdm-project/pdm-backend/releases/tag/2.3.3)

[Compare
Source](https://github.com/pdm-project/pdm-backend/compare/2.3.2...2.3.3)

##### ย ย ย ๐Ÿž Bug Fixes

- Pdm_build.py added twice in sdist file. Fixes
[#&#8203;250](https://github.com/pdm-project/pdm-backend/issues/250)
ย -ย  by [@&#8203;frostming](https://github.com/frostming) in
[https://github.com/pdm-project/pdm-backend/issues/250](https://github.com/pdm-project/pdm-backend/issues/250)
[<samp>(3dd6d)</samp>](https://github.com/pdm-project/pdm-backend/commit/3dd6d78)

##### ย ย ย ย [View changes on
GitHub](https://github.com/pdm-project/pdm-backend/compare/2.3.2...2.3.3)

</details>

---

### Configuration

๐Ÿ“… **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

๐Ÿšฆ **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

โ™ป **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

๐Ÿ”• **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [x] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
erichesse referenced this issue in robert-koch-institut/mex-model Jul 23, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [pdm-backend](https://github.com/pdm-project/pdm-backend) |
build-system.requires | patch | `==2.3.2` -> `==2.3.3` |

---

### Release Notes

<details>
<summary>pdm-project/pdm-backend (pdm-backend)</summary>

###
[`v2.3.3`](https://github.com/pdm-project/pdm-backend/releases/tag/2.3.3)

[Compare
Source](https://github.com/pdm-project/pdm-backend/compare/2.3.2...2.3.3)

##### ย ย ย ๐Ÿž Bug Fixes

- Pdm_build.py added twice in sdist file. Fixes
[#&#8203;250](https://github.com/pdm-project/pdm-backend/issues/250)
ย -ย  by [@&#8203;frostming](https://github.com/frostming) in
[https://github.com/pdm-project/pdm-backend/issues/250](https://github.com/pdm-project/pdm-backend/issues/250)
[<samp>(3dd6d)</samp>](https://github.com/pdm-project/pdm-backend/commit/3dd6d78)

##### ย ย ย ย [View changes on
GitHub](https://github.com/pdm-project/pdm-backend/compare/2.3.2...2.3.3)

</details>

---

### Configuration

๐Ÿ“… **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

๐Ÿšฆ **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

โ™ป **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

๐Ÿ”• **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
mr-kamran-ali referenced this issue in robert-koch-institut/mex-editor Jul 23, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [pdm-backend](https://github.com/pdm-project/pdm-backend) |
build-system.requires | patch | `==2.3.2` -> `==2.3.3` |

---

### Release Notes

<details>
<summary>pdm-project/pdm-backend (pdm-backend)</summary>

###
[`v2.3.3`](https://github.com/pdm-project/pdm-backend/releases/tag/2.3.3)

[Compare
Source](https://github.com/pdm-project/pdm-backend/compare/2.3.2...2.3.3)

##### ย ย ย ๐Ÿž Bug Fixes

- Pdm_build.py added twice in sdist file. Fixes
[#&#8203;250](https://github.com/pdm-project/pdm-backend/issues/250)
ย -ย  by [@&#8203;frostming](https://github.com/frostming) in
[https://github.com/pdm-project/pdm-backend/issues/250](https://github.com/pdm-project/pdm-backend/issues/250)
[<samp>(3dd6d)</samp>](https://github.com/pdm-project/pdm-backend/commit/3dd6d78)

##### ย ย ย ย [View changes on
GitHub](https://github.com/pdm-project/pdm-backend/compare/2.3.2...2.3.3)

</details>

---

### Configuration

๐Ÿ“… **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

๐Ÿšฆ **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

โ™ป **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

๐Ÿ”• **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: Kamran Ali <[email protected]>
cutoffthetop referenced this issue in robert-koch-institut/mex-release Jul 31, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [pdm-backend](https://github.com/pdm-project/pdm-backend) |
build-system.requires | patch | `==2.3.2` -> `==2.3.3` |

---

### Release Notes

<details>
<summary>pdm-project/pdm-backend (pdm-backend)</summary>

###
[`v2.3.3`](https://github.com/pdm-project/pdm-backend/releases/tag/2.3.3)

[Compare
Source](https://github.com/pdm-project/pdm-backend/compare/2.3.2...2.3.3)

##### ย ย ย ๐Ÿž Bug Fixes

- Pdm_build.py added twice in sdist file. Fixes
[#&#8203;250](https://github.com/pdm-project/pdm-backend/issues/250)
ย -ย  by [@&#8203;frostming](https://github.com/frostming) in
[https://github.com/pdm-project/pdm-backend/issues/250](https://github.com/pdm-project/pdm-backend/issues/250)
[<samp>(3dd6d)</samp>](https://github.com/pdm-project/pdm-backend/commit/3dd6d78)

##### ย ย ย ย [View changes on
GitHub](https://github.com/pdm-project/pdm-backend/compare/2.3.2...2.3.3)

</details>

---

### Configuration

๐Ÿ“… **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

๐Ÿšฆ **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

โ™ป **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

๐Ÿ”• **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
cutoffthetop referenced this issue in robert-koch-institut/mex-drop Jul 31, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [pdm-backend](https://github.com/pdm-project/pdm-backend) |
build-system.requires | patch | `==2.3.2` -> `==2.3.3` |

---

### Release Notes

<details>
<summary>pdm-project/pdm-backend (pdm-backend)</summary>

###
[`v2.3.3`](https://github.com/pdm-project/pdm-backend/releases/tag/2.3.3)

[Compare
Source](https://github.com/pdm-project/pdm-backend/compare/2.3.2...2.3.3)

##### ย ย ย ๐Ÿž Bug Fixes

- Pdm_build.py added twice in sdist file. Fixes
[#&#8203;250](https://github.com/pdm-project/pdm-backend/issues/250)
ย -ย  by [@&#8203;frostming](https://github.com/frostming) in
[https://github.com/pdm-project/pdm-backend/issues/250](https://github.com/pdm-project/pdm-backend/issues/250)
[<samp>(3dd6d)</samp>](https://github.com/pdm-project/pdm-backend/commit/3dd6d78)

##### ย ย ย ย [View changes on
GitHub](https://github.com/pdm-project/pdm-backend/compare/2.3.2...2.3.3)

</details>

---

### Configuration

๐Ÿ“… **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

๐Ÿšฆ **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

โ™ป **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

๐Ÿ”• **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants