Skip to content

Fix invalid configuration for mediabox_params in PDFPage class. #1081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 24, 2025

Conversation

pprados
Copy link
Contributor

@pprados pprados commented Feb 25, 2025

Pull request

With some PDF file, see sample,
annotations.pdf
the code crash with TypeError: 'PDFObjRef' object is not iterable

How Has This Been Tested?

I add a test with this file and run pytest

Checklist

  • I have read CONTRIBUTING.md.
  • I have added a concise human-readable description of the change to CHANGELOG.md.
  • I have tested that this fix is effective or that this feature works.
  • I have added docstrings to newly created methods and classes.
  • I have updated the README.md and the readthedocs documentation. Or verified that this is not necessary.

@pprados pprados force-pushed the pprados/fix_mediabox branch from b921c19 to 536d18c Compare February 25, 2025 15:44
@pprados pprados marked this pull request as ready for review February 25, 2025 15:59
@pprados
Copy link
Contributor Author

pprados commented Mar 1, 2025

@PabloCastellano it's fixed

@pprados
Copy link
Contributor Author

pprados commented Mar 3, 2025

@PabloCastellano
Can you revue this PR?

@pprados
Copy link
Contributor Author

pprados commented Mar 5, 2025

@PabloCastellano
Can you revue this PR? Thanks

@pietermarsman pietermarsman self-requested a review March 24, 2025 06:53
@pietermarsman pietermarsman added this pull request to the merge queue Mar 24, 2025
Merged via the queue into pdfminer:master with commit 0c91231 Mar 24, 2025
10 of 11 checks passed
@pietermarsman
Copy link
Member

@pprados Thanks for your time and effort!

pprados added a commit to pprados/unstructured-inference that referenced this pull request Apr 3, 2025
pprados added a commit to pprados/unstructured-inference that referenced this pull request Apr 3, 2025
pprados added a commit to pprados/unstructured-inference that referenced this pull request Apr 3, 2025
pprados added a commit to pprados/unstructured-inference that referenced this pull request Apr 3, 2025
pprados added a commit to pprados/unstructured-inference that referenced this pull request Apr 3, 2025
pprados added a commit to pprados/unstructured-inference that referenced this pull request Apr 3, 2025
pprados added a commit to pprados/unstructured-inference that referenced this pull request Apr 3, 2025
pprados added a commit to pprados/unstructured-inference that referenced this pull request Apr 7, 2025
pprados added a commit to pprados/unstructured-inference that referenced this pull request Apr 8, 2025
pprados added a commit to pprados/unstructured-inference that referenced this pull request Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants