Fix index out of bounds when processing xref stream #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add previous crashing pdfs to test suite
|
Hm, shouldn't CI be running on pull requests? |
|
hold up forgot to add a test case for this PR |
|
Looking good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure of the best way to go through these fuzzing bugs. I had a shot at fixing this one myself, since why let you have all the fun of fixing them :D
But you might have more context with how to fix it so I'd be happy to keep on just filing bug after bug as they're fixed, and just have you fix all of them. It would be a good idea to add regression tests for all the bugs fixed, which I've done here.