Switch to webm-iterable for parsing raw file data #188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I saw the post for Symphonia on Reddit a little while back and it immediately piqued my interest. I love writing code in Rust, and I've actually done a fair amount of work around parsing and writing EBML (basis for mkv/webm). I decided to look into the project to see if there was anything I could do to help on the Matroska front.
I put together this PR in an attempt to:
Overall, I'm satisfied with the outcome. This PR does remove over 1000 lines of code (822 additions and 2078 deletions), it delegates raw EBML packet parsing to the webm-iterable library (some bias here since I wrote it), and the resulting
symphonia-play
binary can play all of the matroska test files. I unfortunately wasn't able to improve the demuxing speed like I had hoped, but the speed also isn't any worse, so a neutral result there.Hopefully you think this is a helpful change! I'm more than happy to talk through any questions or feedback.