Add Connection::create_native_widget_from_rwh() #61
Conversation
Adds a function for creating a native widget from a raw window handle.
Added missing create_native_widget_from_rwh implementations, even if for now they just return "unsupported" errors.
|
Surfman doesn't support iOS platform? |
|
Added macOS and Android in a sub-pr katharostech#1 |
|
Sweet, merged. :) |
|
@pcwalton So as far as the wayland implementation goes, I wasn't sure how to get the size of the wayland surface from the raw window handle, but according to this gfx-rs/gfx#3151 (comment) there isn't really a real size to get. I'm not sure if that will work fine then with an arbitrary size set at widget creation? Would the surface/widget need to be resized at swapchain creation time, or do we not need to worry about it? I don't know how to test Wayland so I haven't tested it. |
|
FYI I just added an extra commit in here that fixes builds on Linux that are made without the I could split it to a separate PR if desired. |
|
Oops, that last commit was broken BTW, don't merge yet! Edit: Actually, it wasn't broken. I was confused, but still don't merge this yet. |
Building on Linux without the `sm-x11` feature was failing. This commit makes sure that surfman doesn't attempt to use x11 when it is not compiled with the `sm-x11` feature.
zicklag
force-pushed
the
native-widget-from-rwh
branch
from
008bb16 to
ad951ef
Compare
|
Closing in favor of servo#172. |
GFX Support Features This PR contains additions to `surfman` needed for supporting the `gfx-backend-gl` effort that is being worked on in gfx-rs/gfx#3151. Still a work in progress at the moment, but it is almost finished I think. This supercedes: pcwalton#61. The PR adds new functions for creating a native widget from a raw window handle and will also contain fixes to allow compiling on MacOS without having to disable unsupported features. These are both features needed by `gfx-backend-gl`.
2 participants
Adds a function for creating a native widget from a raw window handle.
Not tested yet.
Fixes #60.