Update case of binary in goreleaser #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pcjun97 very cool plugin! What do you think of this change? |
|
Hey @accorvin, thanks for noticing this issue and opening a PR for it! I prefer if the Something like: project_name: HashAnnotator
builds:
- binary: '{{ .ProjectName }}'
archives:
- id: latest
name_template: '{{ tolower .ProjectName }}_latest_{{ .Os }}_{{ .Arch }}' |
accorvin
force-pushed
the
fix-binary-case
branch
from
f5026bd
to
cdbab10
Compare
|
Thanks @pcjun97! I had the same thought. I've never used goreleaser before so I wasn't sure if changing the project name would cause any other unexpected issues so wanted to get your input first. Updated. |
We hit an issue when attempting to use this plugin as installed from the GitHub release archive. It appears that Kustomize expects the case of the plugin's binary to match the `Kind` in the hashannotator object. This change updates the goreleaser.yaml file to create a binary with the correct tense.
|
LGTM! |
pcjun97
approved these changes
Jul 15, 2022
accorvin
force-pushed
the
fix-binary-case
branch
from
cdbab10
to
ec9634e
Compare
|
@pcjun97 done. |
|
Thanks @pcjun97! Do you know if a new release will automatically be produced? |
|
@accorvin Sorry for the delay. You can find the latest release here: https://github.com/pcjun97/kustomize-hash-annotator/releases/tag/1.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We hit an issue when attempting to use this plugin as installed from the
GitHub release archive. It appears that Kustomize expects the case of
the plugin's binary to match the
Kindin the hashannotator object.This change updates the goreleaser.yaml file to create a binary with the
correct tense.